Ticket #286 (closed Enhancement: Software changed)
./run script have Perl run-time dependency.
| Reported by: | bland@… | Owned by: | wsanchez@… |
|---|---|---|---|
| Priority: | 4: Nice to have | Milestone: | CalendarServer-4.x |
| Component: | Calendar Server | Severity: | Other |
| Keywords: | Cc: | kurt.leubner@… | |
| Port: |
Description
./run script uses xpath utility to fetch values out of caldavd.plist. This utility is Perl based and adds excessive dependency to CalendarServer bundle. It will be nice to switchover to PyXML inline code instead.
Change History
comment:1 Changed 5 years ago by wsanchez@…
- Status changed from new to assigned
- Milestone set to Later
comment:2 Changed 4 years ago by matthias@…
Hi. I've installed CalendarServer on Ubuntu and it took me an hour to figure out that xpath is used by run.sh to get config keys. It would be nice, if this would at least be mentioned as requirement, see #79. An error message that xpath is not installed would also be nice.
Besides this, I had to change config_key to this:
conf_read_key () {
local key="$1"; shift;
# FIXME: This only works for simple values (no arrays, dicts) tr '\n' ' ' < "${config}" \
| xpath -e "/plist/dict/*[preceding-sibling::key[1]='${key}'" 2> /dev/null \ | head -n 1 \ | sed -n 's|<[<][<]*>\([<]*\)</[<][<]*>.*$|\1|p';
}
as xapth requires the "-e" flag and it returns two nodes.
Thanks,
Matthias Ringwald
comment:10 Changed 3 months ago by wsanchez@…
- Status changed from assigned to closed
- Resolution set to Software changed
- Milestone changed from Later to CalendarServer-4.x
This was fixed in r6400, 2010-10-05.
That's a fair point, though that functionality is only for obtaining a specific config key... Also, the ./run script is only meant for developers, not users, so it's not a high priority.
If someone can whip up a PyXML-based xpath tool, I'd be happy to call into that instead. Even better, use elementtree if that's possible, since we'd like to get rid of PyXML as well).