Apache directory service types broken?

[msantos@…]

It appears that the Apache directory service types are broken. Code in udpateDirectoryService() in config.py seems to be trying to validate the directory service parameters from the config file against the known keywords, but there is no entry for them in serviceDefaultParams[], so the code takes a KeyError exception at this line:

if param not in serviceDefaultParams[dsType]:

because dsType is twistedcaldav.directory.apache.DigestDirectoryService, but the list in config.py only has entries for:

twistedcaldav.directory.xmlfile.XMLDirectoryService twistedcaldav.directory.appleopendirectory.OpenDirectoryService

Maybe that list is supposed to be updated somewhere else (from apache.py?), but I couldn't find any such place.

[wsanchez@…]

See ​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503727 for a Debian bug on this and a patch.

[agx@…]

Hi Winfredo, the patch makes sense to me. Can it be applied?

-- Guido

[agx@…]

Replying to msantos@…:

Hi Winfredo, the patch in the BTS

[agx@…]

Whoops. I didn't mean to change the description, just wanted to add a comment.

Hi Winfredo, the patch makes sense to me. Can it be applied?

Sorry for the noise.

[wsanchez@…]

OK, I applied these and some other work that seemed obviously lacking. The files appear to read in correctly, but a couple of things (at least) are still broken:

• the basic verifyCredentials bits still don't work for me; I wasn't able to auth
• the digest verifyCredentials bits are unimplemented
• the digest directory service doesn't filter out records with a non-matching realm (realm seems irrelevant to basic)

[wsanchez@…]

This functionality was removed for 3.0

[kurt.leubner@…]

Cc Me!