Projects
Wiki     Timeline     Roadmap     Browse Source     View Tickets     New Ticket     Search

Ticket #311 (closed Enhancement: Software changed)

Opened 21 months ago

Last modified 17 months ago

Add API hooks to control the flags for Kerberos delegate

Reported by: ssorce@… Owned by: cdaboo@…
Priority: 3: Important Milestone:
Component: PyKerberos Severity: Other
Keywords: Cc: ssorce@…

Description

We use PyKerberos in the FreeIPA project. Up to version one we carried a patch to set the delegate flag by default. With version 1.1 of PyKerberos I added a few flags to the init function so that it is easy to control the flags without patching the code. The code is backwards compatible as it adds a default argument to the function that is set to the previous defaults.

It would be nice if you would consider including this patch in the upstream distribution.

Attachments

PyKerberos-delegation.patch Download (6.1 KB) - added by ssorce@… 21 months ago.
Same patch as before but with defaults hardcoded in the C code.

Change History

Changed 21 months ago by cdaboo@…

  • cc cdaboo@… added

Cc Me!

Changed 21 months ago by cdaboo@…

  • cc ssorce@… added; cdaboo@… removed
  • owner changed from wsanchez@… to cdaboo@…
  • status changed from new to assigned

Changed 21 months ago by cdaboo@…

The default for gss_flags in kerberos.c is 0, but it needs to be GSS_C_MUTUAL_FLAG | GSS_C_SEQUENCE_FLAG to match the original default.

Changed 21 months ago by ssorce@…

Isn't it sufficient to have gssflags=GSS_C_MUTUAL_FLAG | GSS_C_SEQUENCE_FLAG in pysrc/kerberos.c ?

Changed 21 months ago by ssorce@…

Further testing seem to confirm it is not enough. Uploading revised patch.

Changed 21 months ago by ssorce@…

Same patch as before but with defaults hardcoded in the C code.

Changed 21 months ago by cdaboo@…

  • status changed from assigned to new

The pysrc file is not part of the module as built by setup.py. It is primarily there to display what the python api of the module looks like.

New patch looks good. I will apply this soon. Thanks for the submission.

Changed 19 months ago by wsanchez@…

  • priority changed from 4: Nice to have to 3: Important
  • summary changed from Patch for PyKerberos to Add API hooks to control the flags for Kerberos delegate

Changed 17 months ago by cdaboo@…

  • status changed from new to closed
  • resolution set to Software changed

Patch incorporated in r3947.

Note: See TracTickets for help on using tickets.