pykerberos: support for heimdal/linux

[agx@…]

Hi, attached is a bunch of patches that adds support for linux/heimdal. They might not be as clean as possible but should show fairly well what to do. Please apply as approprioate. The patch order is:

• printf-cleanups: generic cleanups
• include-stdlib: include stdlib for definition of free(3)
• kerberos-includes: fixup kerberos includes for non macosx
• declare-nt-service: gss_krb5_nt_service_name is declared differently in heimdal
• python-include: include "python.h"
• fix-setup: detect "linux2" and pass correct linker flags

Cheers,

-- Guido

[andrew@…]

Make the MacOS X specific includes more specific.

[agx@…]

include stdlib.h for declaration of free(2)

[agx@…]

I've updated the patches so they apply against latest SVN. Please let me know about any issues with them.

[wsanchez@…]

Where is C_MACOSX defined?

[wsanchez@…]

printf-cleanups applied in r123

[wsanchez@…]

include-stdlib applied in r124

[wsanchez@…]

The #ifdef linux stuff is undesirable, and I think we can make it work without.

Specifically, in setup.py, we should find the framework and do the right -Ifoo magic so we don't need "Kerberos/" in the includes. Parking BSD stuff into frameworks is wonky, so we should use the "regular" includes in code and fix the OS X weirdness in setup.py. I think.

[agx@…]

Remove Kerberos/ from the include statements

[agx@…]

I've updated fix-setup and kerberos-includes (as you suggested) to:

• not use the Kerberos/ on OSX and gssapi/ prefixes on Linux
• pass in the include patchs via setup.py
• parse the correct link args on linux via krb5-config

declate-nt-service can be dropped since it's only needed for heimdal and I'm also building against MIT now. I'm not sure if the include patch is correct for Mac OSX, please modify if it isn't. Cheers,

-- Guido

[wsanchez@…]

I put in a fix to setup.py in r200, which is based on your patch, but took out the sys.platform conditionals.  krb5-config should work on OS X also.

[wsanchez@…]

python-include is covered in r201

[wsanchez@…]

kerberos-includes covered in r202

[wsanchez@…]

I think r202 should work for you.  Let me know if anything else is needed.

[agx@…]

Fix include path for linux

[agx@…]

Looks almost fine now but "krb5-config --cflags" doesn't give anything reasonable on Linux either, that's why I hardcoded the include path previously. I've update "fix-setup" again. This one patch is all that's needed now, can it be applied?

[wsanchez@…]

OK, I think the problem is actually that the #include is wrong, and OS X's krb5-config isn't broken either...

Try out r217 and let me know if that works.  (Thanks, Guido)