Projects
Wiki     Timeline     Roadmap     Browse Source     View Tickets     New Ticket     Search

Ticket #38 (closed Defect: Software changed)

Opened 7 years ago

Last modified 5 months ago

Several incorrect usages of Deferreds

Reported by: dreid@… Owned by: wsanchez@…
Priority: 1: Blocker Milestone: CalendarServer-1.0
Component: Calendar Server Severity: Serious
Keywords: Cc: kurt.leubner@…
Port:

Description

These uses are of the pattern: 

something = someDeferredFunction()
assert something.called
result = something.result

# do things with the result

This works by accident only.

Change History

comment:1 Changed 7 years ago by wsanchez@…

  • Priority changed from 5: Not set to 1: Blocker
  • Milestone set to Preview 1

comment:2 Changed 7 years ago by wsanchez@…

I see two cases of this: 

                c = child.createCalendarCollection()
                assert c.called
                c = c.result

One in repository.py, and one in static.py.  This is now on trunk, not on a branch, so we need to clean that up there.

comment:3 Changed 7 years ago by wsanchez@…

  • Summary changed from users/cdaboo/acl-merge includes several incorrect usages of Deferreds to Several incorrect usages of Deferreds

comment:4 Changed 6 years ago by wsanchez@…

  • Owner changed from cdaboo@… to wsanchez@…

I think I cleaned up the last of these with the directory auto-provisioning work.

comment:5 Changed 6 years ago by wsanchez@…

  • Status changed from new to closed
  • Resolution set to fixed

comment:6 Changed 6 years ago by wsanchez@…

  • Milestone changed from Preview 1 to Version One

Milestone Preview 1 deleted

comment:7 Changed 5 months ago by kurt.leubner@…

  • Cc kurt.leubner@… added

Cc Me!

comment:8 Changed 5 months ago by kurt.leubner@…

  • Cc kurt.leubner@… removed

Cc Me!

comment:9 Changed 5 months ago by kurt.leubner@…

  • Cc kurt.leubner@… added

Cc Me!

Note: See TracTickets for help on using tickets.