incompatible with python-sqlparse 0.1.3 (Debian Testing)

[patrick.ohly@…]

When starting the server with the system's python-sqlparse 0.1.3 instead of the version 0.1.2 that it would use as fallback, the server fails with:

  File "/home/pohly/src/CalendarServer/CalendarServer/twext/enterprise/dal/parseschema.py", line 232, in nextColumn
    return self.parseColumn(maybeIdent.value)
  File "/home/pohly/src/CalendarServer/CalendarServer/twext/enterprise/dal/parseschema.py", line 307, in parseColumn
    theType = SQLType(typeName.value.encode("utf-8"), typeLength)
AttributeError: 'NoneType' object has no attribute 'encode'

Adding some print statements showed that it fails for varchar entries:

txdav/common/datastore/sql_schema/current.sql
create table CALENDAR_HOME (
  RESOURCE_ID      integer      primary key default nextval('RESOURCE_ID_SEQ'),
=>  OWNER_UID        varchar(255) not null unique
);

In python-sqlparse, typeName.value was "varchar", same as the string representation of typeName itself. Based on that observation here's a crude patch which uses str(typeName) as default. Works for me, no idea whether it is the right fix...

CalendarServer/twext/enterprise/dal/parseschema.py

@@ -304 +304 @@
                 # something else
                 typeLength = None
                 self.pushback(maybeTypeArgs)
-        theType = SQLType(typeName.value.encode("utf-8"), typeLength)
+        theType = SQLType((typeName.value or str(typeName)).encode("utf-8"), typeLength)
         theColumn = self.table.addColumn(
             name=name.encode("utf-8"), type=theType
         )

[glyph@…]

Fixing formatting.

[glyph@…]

Thanks for reporting this issue. The real problem here is that sqlparse doesn't have a very stable API at this point, so using the exactly required version is very important.

With your patch, does the full test suite and CalDAVTester suite pass?

[mail@…]

btw. issue #486 modifies the same line of code.

[kurt.leubner@…]

Cc Me!

[kurt.leubner@…]

Cc Me!

[kurt.leubner@…]

Cc Me!

[wsanchez@…]

Same problem as #486?

[carlos@…]

Cc Me!